Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Added MySQL support #171 #215

Closed
wants to merge 3 commits into from
Closed

fix : Added MySQL support #171 #215

wants to merge 3 commits into from

Conversation

talktogauravsingh
Copy link

@talktogauravsingh talktogauravsingh commented Sep 30, 2023

This PR adds MySQL support.

/claim #171

Signed-off-by: Gaurav Singh <[email protected]>
@algora-pbc algora-pbc bot mentioned this pull request Sep 30, 2023
@JhumanJ
Copy link
Owner

JhumanJ commented Oct 1, 2023

Looks like the right approach to me 🙌 I'll check early this week. Did you try running the tests with mysql as well?

@talktogauravsingh
Copy link
Author

Looks like the right approach to me 🙌 I'll check early this week. Did you try running the tests with mysql as well?

Yeah, I run test cases with both MySQL and PostgreSQL, and I have successfully passed all the test cases.

@JhumanJ
Copy link
Owner

JhumanJ commented Oct 4, 2023

Hi, I just tested this and it seems to be working fine with both Psql and mysql. Would it be possible to also change the github action in laravel.yml to run the tests with mysql? This link how to add support to mysql for github actions. Essentially:

  • Add a mysql service (keep the postgres one)
  • After running the tests with postgres version, change the .env database variables file to use these values:
# database
DB_CONNECTION=mysql
DB_HOST=mysql
DB_PORT=3306
DB_DATABASE=test
DB_USERNAME=root
DB_PASSWORD=password
  • Run the test again, this time with mysql.

Thanks!

@JhumanJ JhumanJ closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants